From bb3265b9d3ceaa43c645cfce7b03d90dbba126db Mon Sep 17 00:00:00 2001 From: Dudemanguy Date: Mon, 17 Feb 2025 17:28:11 -0600 Subject: [PATCH] stream_cdda: deprecate undocumented --cdda-span-{a,b} options You probably wouldn't guess what this does from the name alone, but it actually selects a range of tracks to play. It's slightly different than using --start because it confines the range to just that track and you cannot seek before it. The functionality is useful, but you can accomplish exactly the same thing with --start and --end. Also the implementation of the cdda option is weird because starting from a track after 1 makes it impossible to seek before it. There's no reason to have this when using the core option is simply better and works fine. --- DOCS/interface-changes/cdda-span.txt | 1 + stream/stream_cdda.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 DOCS/interface-changes/cdda-span.txt diff --git a/DOCS/interface-changes/cdda-span.txt b/DOCS/interface-changes/cdda-span.txt new file mode 100644 index 0000000000..53fd2b0b5d --- /dev/null +++ b/DOCS/interface-changes/cdda-span.txt @@ -0,0 +1 @@ +deprecate `--cdda-span-a` and `--cdda-span-b` diff --git a/stream/stream_cdda.c b/stream/stream_cdda.c index 9d8a18a6a0..05f689f763 100644 --- a/stream/stream_cdda.c +++ b/stream/stream_cdda.c @@ -76,8 +76,8 @@ const struct m_sub_options stream_cdda_conf = { {"overlap", OPT_INT(search_overlap), M_RANGE(0, 75)}, {"toc-offset", OPT_INT(toc_offset)}, {"skip", OPT_BOOL(skip)}, - {"span-a", OPT_INT(span[0])}, - {"span-b", OPT_INT(span[1])}, + {"span-a", OPT_INT(span[0]), .deprecation_message = "--start=#N"}, + {"span-b", OPT_INT(span[1]), .deprecation_message = "--end=#N"}, {"cdtext", OPT_BOOL(cdtext)}, {0} },