leeexin/Velix-MPV-Core
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

video/filter/vf_gpu_vulkan: parent opts to ctx

Browse Source 
And only free explicitly on success. On failure it will be freed by
parent.

Fixes: [Bug] vf_gpu_vulkan: Use-after-free of ctx_opts
This commit is contained in:
nanahi authored and Kacper Michajłow committed 2026-06-08 01:26:23 +02:00
1 parent 579a62c2ba
commit f29fcafb81
1 file changed
+4 -4
Download Patch File Download Diff File Expand all files Collapse all files
video/filter/vf_gpu_vulkan.c
+4 -4
View File
@@ -67,19 +67,17 @@ static struct offscreen_ctx *vk_offscreen_ctx_create(struct mpv_global *global,
goto error;
struct pl_vk_inst_params pl_vk_params = {0};
struct ra_ctx_opts *ctx_opts = mp_get_config_group(NULL, global, &ra_ctx_conf);
struct ra_ctx_opts *ctx_opts = mp_get_config_group(ctx, global, &ra_ctx_conf);
pl_vk_params.debug = ctx_opts->debug;
talloc_free(ctx_opts);
mppl_log_set_probing(vk->pllog, true);
vk->vkinst = pl_vk_inst_create(vk->pllog, &pl_vk_params);
mppl_log_set_probing(vk->pllog, false);
if (!vk->vkinst)
goto error;
struct vulkan_opts *vk_opts = mp_get_config_group(NULL, global, &vulkan_conf);
struct vulkan_opts *vk_opts = mp_get_config_group(ctx, global, &vulkan_conf);
vk->vulkan = mppl_create_vulkan(vk_opts, vk->vkinst, vk->pllog, VK_NULL_HANDLE,
ctx_opts->allow_sw);
talloc_free(vk_opts);
if (!vk->vulkan)
goto error;
@@ -97,6 +95,8 @@ static struct offscreen_ctx *vk_offscreen_ctx_create(struct mpv_global *global,
ctx->ra = ractx->ra;
ctx->priv = vkctx;
talloc_free(ctx_opts);
talloc_free(vk_opts);
return ctx;
error: